Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change gem name from scss-lint to scss_lint in README.md #124

Merged
merged 2 commits into from
Jul 8, 2016
Merged

Change gem name from scss-lint to scss_lint in README.md #124

merged 2 commits into from
Jul 8, 2016

Conversation

chrisnicotera
Copy link

Although the project is still named scss-lint, the Gem is now named scss_lint.

I assume scss-lint is left in place for legacy purposes, as it seems to have changed ownership from causes to brigade. The last release of scss-lint (causes) is 0.38.0, from May 3, 2015.

Although the project is still named scss-lint, the Gem is now named `scss_lint`.

I assume scss-lint is left in place for legacy purposes, as it seems to have changed ownership from [causes](https://github.com/causes) to [brigade](https://github.com/brigade). The last release of `scss-lint` (causes) is 0.38.0, from May 3, 2015.
@ahmednuaman
Copy link
Owner

What about the gemfile too?

@rek
Copy link

rek commented Jun 1, 2016

Gemfile is updated, it is confusing to not have the readme updated too.

+1

@alexcanessa
Copy link

@ahmednuaman could I suggest to merge this PR sooner than later?

@ahmednuaman
Copy link
Owner

Why are the tests failing?

@chrisnicotera
Copy link
Author

chrisnicotera commented Jul 6, 2016

@ahmednuaman https://travis-ci.org/ahmednuaman/grunt-scss-lint/jobs/80890455#L317-L324

The test didn't finish in time. This is also happening on Appveyor although with a couple of other, unrelated errors.

Perhaps consider increasing the mocha test timeout since these tests are spawning grunt and most of them are approaching the 2000ms default?

I've only modified README.md, so the tests failing for this PR is moot, but that should resolve the issue that both CI suites are experiencing.

@ahmednuaman
Copy link
Owner

Try to rebase and try again

@chrisnicotera
Copy link
Author

@ahmednuaman Should be good to go

@ahmednuaman ahmednuaman merged commit 4b426ec into ahmednuaman:master Jul 8, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants