Use the "app" argument if available #165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `app` argument passed to `included` is the host app or parent addon and the addon has a `import` api exposed since ember-cli/ember-cli#5877. This PR does no changes to normal ember app but the app with a lazy engine which depend on `ember-highcharts` directly, it could distribute the `hightcharts` vendor to the `engine-vendor.js` instead of the `vendor.js` of the whole app so that other engines do not have to download the `hightcharts` vendor(also need other tricks like add the "ember-highcharts" to the `addons.blacklist` of the whole app option).
nlfurniss
reviewed
Jun 25, 2019
stefanpenner
approved these changes
Jun 25, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
appargument passed toincludedis the host app or parent addon and the addon has aimportapi exposed since ember-cli/ember-cli#5877.This PR does no changes to normal ember app but the app with a lazy engine which depend on
ember-highchartsdirectly, it could distribute thehightchartsvendor to theengine-vendor.jsinstead of thevendor.jsof the whole app so that other engines do not have to download thehightchartsvendor(also need other tricks like adding the "ember-highcharts" to theaddons.blacklistof the whole app option).