Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use magick executable for ImageMagick on Windows #594

Closed
wants to merge 2 commits into from
Closed

Use magick executable for ImageMagick on Windows #594

wants to merge 2 commits into from

Conversation

coldacid
Copy link

Because of name conflicts with some system executables, ImageMagick uses a single executable magick on the Windows platform. This commit reflects that, and makes it possible to use ImageMagick on Windows via the gm module again.

Fixes #559

Because of name conflicts with some system executables, ImageMagick uses a single executable `magick` on the Windows platform. This commit reflects that, and makes it possible to use ImageMagick on Windows via the `gm` module again.
@coldacid
Copy link
Author

Failed check seems to be an issue with the runner for Node 0.10. All other build environments are green.

@Mithgol
Copy link

Mithgol commented Dec 9, 2016

+1

(This comment is a tool that brings this issue from https://github.com/notifications to https://github.com/notifications/participating for me. Just raising my personal awareness.)

@Mithgol
Copy link

Mithgol commented Dec 11, 2016

Until this issue is fixed, the most obvious workaround is to install and use GraphicsMagick (instead of ImageMagick) on Windows.

@coldacid
Copy link
Author

@Mithgol I'd suggest to just do npm install github:coldacid/gm#patch-1 instead, considering the module hasn't updated since I submitted this PR. Iif the gm module updates without merging in my fix should anyone consider changing the backend tools to work around the problem.

@gus27
Copy link

gus27 commented Jan 15, 2017

I'd like this issue to be fixed, too. But I'd like to suggest to adapt this solution so that is not limited to the Windows platform. Maybe the imageMagick option can be set to a string like "magick" to indicate the new single command. With imageMagick:true it would work like before with the several commands.

@piotr-cz piotr-cz mentioned this pull request Jan 23, 2019
@piotr-cz
Copy link
Contributor

#774 fixes the issue with manual switch so user can decide based on ImageMagick version.

@aheckmann
Copy link
Owner

Fixed by #846. Released in v1.25.0.

@aheckmann aheckmann closed this Sep 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ImageMagick command called 'magick' on Windows
5 participants