fix: get and create tasks

- Fix #148 remove ID parameter from Get-QlikTask - Fix assigning properties and tags when creating tasks
ahaydon · Aug 24, 2021 · 83b3cd9 · 83b3cd9
1 parent 3124528
commit 83b3cd9
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 6 deletions.
diff --git a/resources/task.ps1 b/resources/task.ps1
@@ -105,8 +105,6 @@ function Get-QlikReloadTask {
 function Get-QlikTask {
     [CmdletBinding()]
     param (
-        [parameter(Position = 0)]
-        [string]$id,
         [string]$filter,
         [switch]$full,
         [switch]$raw
@@ -167,8 +165,8 @@ function New-QlikTask {
             };
         }
 
-        if ($PSBoundParameters.ContainsKey("customProperties")) { $task.customProperties = @(GetCustomProperties $customProperties) }
-        if ($PSBoundParameters.ContainsKey("tags")) { $task.tags = @(GetTags $tags) }
+        if ($PSBoundParameters.ContainsKey("customProperties")) { $task.task.customProperties = @(GetCustomProperties $customProperties) }
+        if ($PSBoundParameters.ContainsKey("tags")) { $task.task.tags = @(GetTags $tags) }
 
         $json = $task | ConvertTo-Json -Compress -Depth 10
 

diff --git a/tests/task.tests.ps1 b/tests/task.tests.ps1
@@ -48,9 +48,9 @@ Describe "New-QlikTask" {
                 -customProperties 'environment=development'
 
             $task.task.name | Should Be 'Reload App'
-            $task.task.tags | Should -HaveCount 1
+            $task.task.tags.Count | Should -BeExactly 1
             $task.task.app.id | Should Be '982a578f-d335-4e4f-81be-c031e6acb780'
-            $task.task.customProperties | Should -HaveCount 1
+            $task.task.customProperties.Count | Should -BeExactly 1
 
             Assert-VerifiableMock
         }