Changes per issue 10 discussion #15
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated former implementation to not mutate the pasted in options hash. This change allows use with the caches_action method in ActiveSupport. Also added instrument = true to every call of write_fragment. Fixed typo in demo app that makes it not work.
Previously the railtie was requiring the application_controller on load of `action_controller`, which failed with certain rails applications. `before_configuration` comes later and ensure the ApplicationController already loaded.
|
Any reason this isn't getting merged? |
|
+1 for merging. The current gem doesn't work at all for me, nor does the head of the repo. Using both cache and redis storage I couldn't get Cashier.tags to return anything other than an empty array. Installed from this pull request and everything works perfectly. Using Rails 4 and Ruby 2. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here are the changes that should fix #6 and #8.