[FEATURE] 바텀시트 컴포넌트 #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
onschan
reviewed
Apr 12, 2023
onschan
reviewed
Apr 12, 2023
| document.body.style.cssText = | ||
| "overflow-y: hidden; touch-action: none; -ms-touch-action: none; -webkit-overflow-scrolling: none; overscroll-behavior: none;"; | ||
| } else { | ||
| document.body.style.cssText = "overflow-y: overlay;"; |
There was a problem hiding this comment.
- [css-overflow-4] Do not remove overflow: overlay w3c/csswg-drafts#6090
- https://stackoverflow.com/questions/23200639/transparent-scrollbar-with-css/56365213#56365213
- https://caniuse.com/css-overflow-overlay
overflow-y: overlay의 사용이 사파리, 파폭에서는 제한적일 수 있겠네요. 인지정도만 하면 좋을 것 같아요 🤔
There was a problem hiding this comment.
으흠...!! 이 부분에 대해 좀 더 찾아보고 공유드리겠습니다 : )
onschan
reviewed
Apr 12, 2023
| const useOnClickOutside = <T extends HTMLElement>( | ||
| ref: RefObject<T> | ForwardedRef<T>, | ||
| handler: () => void, | ||
| exceptEl?: HTMLElement | null |
There was a problem hiding this comment.
expectEl을 경험상 배열로 받을 수 있게하면 조금 더 확장성이 높더라구여(반영해야된다는 말은 아닙니다)
There was a problem hiding this comment.
오 맞네요!! 음!! 제가 이번주주말까진 너무 바빠서
뭔가 반영해야하는 이슈가 생기면 추후에 해보도록 해요!
onschan
approved these changes
Apr 12, 2023
Co-authored-by: Seungchan On <[email protected]>
jtwjs
approved these changes
Apr 14, 2023
# Conflicts: # src/app/layout.tsx # src/styles/themes/foundations/fonts.ts
createhb21
changed the title
|
@jtwjs I Gotcha ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#12
사실 바텀시트(Drawer)의 경우 직접 제작하는 것보다 상용 라이브러리를 도입하는 것이 훨씬 간편하다고 판단했습니다만,
다양한 라이브러리 중 chakra-ui에서 제공하는 Drawer를 사용하고자 했는데, emotion을 기반으로 하는 라이브러리라서 styled-components를 사용하는 저희로써는 chakra-ui를 사용할 수가 없더라구요.
그래서 다른 UI 라이브러리를 찾아보고 논의해봐야할 것 같습니다만, 우선적으로 온보딩 페이지 개발을 위해서 UI 라이브러리 사용하지 않고 만든 바텀시트에 대한 PR을 올립니다 !
바텀시트에 대한 프리뷰는 다음 링크 참고바랍니다.