Having the threshold also on OrTrigger?

[sneko]

Hi @agronholm ,

Just curious : you added the threshold parameter onto AndTrigger but I'm wondering if you plan or if you could add it to the OrTrigger?

In my case I may have different intervals that can sometimes be distant from 0, 1 or 2 seconds and I would like to avoid triggering all of them, but just one when in the same threshold/window.

Thank you,

[agronholm]

Sounds like something I would like to consider. I have more important work to do on v4.0 first though.

[sneko]

Hi @agronholm , is it still something on your roadmap?

Thank you,

[agronholm]

Yes, have a look at #465.

[sneko]

@agronholm inside there is a check:

"threshold" value for OrTrigger (#427)

It seems it should point to this current one #453 (I didn't see threshold mention in the #427)?

[agronholm]

It seems it should point to this current one #453 (I didn't see threshold mention in the #427)?

Corrected.

[agronholm]

I'm looking into getting this to v4.0. If you want this feature, the best course of action would be to make a PR against master. I was not sure how the threshold logic would work with OrTrigger so I got a bit confused trying to implement it. I would rather delegate this to someone while I work on other features.

[rafalkrupinski]

With stateful combining triggers now, what problem does threshold solve?

[HomerusJa]

Just trying to understand the feature right now. As far as I understand, if a trigger triggers the next OrTrigger, you dont want that OrTrigger to be triggered again for threshold seconds, correct? If that, maybe we should pick another name as this is a completely different functionality as the threshold parameter for the AndTrigger. I would suggest something like cooldown_period, as it is used in similar contexts elsewhere, accurately describes the functionality, and is distinct from the AndTriggers threshold concept. If that is correct, I might give it a try implementing it myself before Christmas 🎄