Merge pull request pybop-team#285 from pybop-team/284-drop-python-38

Increment `Python > 3.8`
agriyakhetarpal · Apr 12, 2024 · 040a8b1 · 040a8b1
2 parents 0509598 + 433d10c
commit 040a8b1
Show file tree

Hide file tree

Showing 9 changed files with 5 additions and 12 deletions.
diff --git a/.github/workflows/test_on_push.yaml b/.github/workflows/test_on_push.yaml
@@ -59,7 +59,7 @@ jobs:
       fail-fast: false
       matrix:
         os: [ubuntu-latest, windows-latest, macos-latest]
-        python-version: ["3.8", "3.9", "3.10", "3.11", "3.12"]
+        python-version: ["3.9", "3.10", "3.11", "3.12"]
         exclude: # We run the coverage tests on Ubuntu with Python 3.12
           - os: ubuntu-latest
             python-version: "3.12"

diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -2,6 +2,7 @@
 
 ## Features
 
+- [#285](https://github.com/pybop-team/PyBOP/pull/285) - Drop support for Python 3.8.
 - [#275](https://github.com/pybop-team/PyBOP/pull/275) - Adds Maximum a Posteriori (MAP) cost function with corresponding tests.
 - [#273](https://github.com/pybop-team/PyBOP/pull/273) - Adds notebooks to nox examples session and updates CI workflows for change.
 - [#250](https://github.com/pybop-team/PyBOP/pull/250) - Adds DFN, MPM, MSMR models and moves multiple construction variables to BaseEChem. Adds exception catch on simulate & simulateS1.

diff --git a/README.md b/README.md
@@ -77,7 +77,7 @@ pip install -e "path/to/pybop"
 To check whether PyBOP has been installed correctly, run one of the examples in the following section. For a development installation, please refer to the [contributing guide](https://github.com/pybop-team/PyBOP/blob/develop/CONTRIBUTING.md#Installation).
 
 ### Prerequisites
-To use and/or contribute to PyBOP, first install Python (3.8 — 3.12). On a Debian-based distribution, this looks like:
+To use and/or contribute to PyBOP, first install Python (3.9 — 3.12). On a Debian-based distribution, this looks like:
 
 ```bash
 sudo apt update

diff --git a/pybop/__init__.py b/pybop/__init__.py
@@ -5,7 +5,6 @@
 # This file is adapted from Pints
 # (see https://github.com/pints-team/pints)
 #
-from __future__ import annotations
 import sys
 from os import path
 

diff --git a/pybop/models/base_model.py b/pybop/models/base_model.py
@@ -1,5 +1,3 @@
-from __future__ import annotations
-
 import copy
 from dataclasses import dataclass
 from typing import Any, Dict, Optional

diff --git a/pyproject.toml b/pyproject.toml
@@ -17,15 +17,14 @@ license = { file = "LICENSE" }
 classifiers = [
   "Development Status :: 3 - Alpha",
   "License :: OSI Approved :: BSD License",
-  "Programming Language :: Python :: 3.8",
   "Programming Language :: Python :: 3.9",
   "Programming Language :: Python :: 3.10",
   "Programming Language :: Python :: 3.11",
   "Programming Language :: Python :: 3.12",
   "Intended Audience :: Science/Research",
   "Topic :: Scientific/Engineering",
 ]
-requires-python = ">=3.8, <3.13"
+requires-python = ">=3.9, <3.13"
 dependencies = [
   "pybamm>=23.5",
   "numpy>=1.16",

diff --git a/scripts/ci/build_matrix.sh b/scripts/ci/build_matrix.sh
@@ -9,7 +9,7 @@
 
 # To update the matrix, the variables below can be modified as needed.
 
-python_version=("3.8" "3.9" "3.10" "3.11" "3.12")
+python_version=("3.9" "3.10" "3.11" "3.12")
 os=("ubuntu-latest" "windows-latest" "macos-latest")
 # This command fetches the last three PyBaMM versions excluding release candidates from PyPI
 pybamm_version=($(curl -s https://pypi.org/pypi/pybamm/json | jq -r '.releases | keys[]' | grep -v rc | tail -n 3 | paste -sd " " -))

diff --git a/tests/unit/test_cost.py b/tests/unit/test_cost.py
@@ -1,5 +1,3 @@
-from __future__ import annotations
-
 import numpy as np
 import pytest
 

diff --git a/tests/unit/test_likelihoods.py b/tests/unit/test_likelihoods.py
@@ -1,5 +1,3 @@
-from __future__ import annotations
-
 import numpy as np
 import pytest