Nullify array of the to be 'deleted' objects

Nullify array of the to be 'deleted' objects, this was causing a reference and the AR objects were not GCed then.
agrare · Apr 11, 2017 · 776aee8 · 776aee8
1 parent df7efdb
commit 776aee8
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 0 deletions.
diff --git a/app/models/ems_refresh/save_inventory.rb b/app/models/ems_refresh/save_inventory.rb
@@ -53,6 +53,8 @@ def save_vms_inventory(ems, hashes, target = nil)
     _log.info "#{log_header} Duplicate unique values found: #{dup_vms_uids.inspect}" unless dup_vms_uids.empty?
 
     invalids_found = false
+    # Clear vms, so GC can clean them
+    vms = nil
 
     ActiveRecord::Base.transaction do
       hashes.each do |h|

diff --git a/app/models/ems_refresh/save_inventory_helper.rb b/app/models/ems_refresh/save_inventory_helper.rb
@@ -43,6 +43,8 @@ def save_inventory_multi(association, hashes, deletes, find_key, child_keys = []
     end
     deletes = deletes.to_a
     deletes_index = deletes.index_by { |x| x }
+    # Alow GC to clean the AR objects as they are removed from deletes_index
+    deletes = nil
 
     child_keys = Array.wrap(child_keys)
     remove_keys = Array.wrap(extra_keys) + child_keys