Merge pull request ManageIQ#19751 from djberg96/miq_provision_workflo…

…w_refactor

Remove unused conditional from class_for_platform in MiqProvisionWorkflow

app/models/miq_provision_workflow.rb

@@ -3,17 +3,23 @@ def self.base_model
     MiqProvisionWorkflow
   end
 
+  # Find the appropriate workflow class for the given 'platform' string.
+  #
+  # @example openstack
+  #   "ManageIQ::Providers::Openstack::CloudManager::ProvisionWorkflow"
+  #
+  # @param platform [String]
+  #   A string of the one of the ManageIQ providers. The case of this
+  #   string is ignored.
+  #
+  # @return [Constant] A scoped provider constant name.
+  #
   def self.class_for_platform(platform)
     classy = platform.classify
 
-    if classy =~ /(.*)Infra/
-      find_matching_constant("MiqProvision#{classy}Workflow") ||
-        find_matching_constant("ManageIQ::Providers::#{$1}::InfraManager::ProvisionWorkflow")
-    else
-      find_matching_constant("MiqProvision#{classy}Workflow") ||
-        find_matching_constant("ManageIQ::Providers::#{classy}::CloudManager::ProvisionWorkflow") ||
-        find_matching_constant("ManageIQ::Providers::#{classy}::InfraManager::ProvisionWorkflow")
-    end
+    find_matching_constant("MiqProvision#{classy}Workflow") ||
+      find_matching_constant("ManageIQ::Providers::#{classy}::CloudManager::ProvisionWorkflow") ||
+      find_matching_constant("ManageIQ::Providers::#{classy}::InfraManager::ProvisionWorkflow")
   end
 
   def self.find_matching_constant(string)