Skip to content

Commit

Permalink
Reverse the default of wait_for_worker_monitor
Browse files Browse the repository at this point in the history
A majority of workers do not need to wait for the server to start, so
changing the default simplifies the code and also identifies which
workers actually need to wait.  In researching this, we found that the
only reason that workers are waiting is to actually wait for the vmware
broker to start and provide its connection pool.  Follow up PRs will
change this from wait_for_worker_monitor to "wait for broker", and we
can further make this more specific to vmware only classes.

See also
ManageIQ/manageiq#14257 (comment)
for a description of how the wait_for_worker_monitor manifests as a
"wait for broker" scenario.

(transferred from ManageIQ/manageiq@9e99ba0)
  • Loading branch information
Fryguy committed Jul 25, 2017
1 parent 4f118b4 commit 9875de1
Showing 1 changed file with 0 additions and 2 deletions.
2 changes: 0 additions & 2 deletions app/models/miq_vim_broker_worker/runner.rb
Original file line number Diff line number Diff line change
@@ -1,6 +1,4 @@
class MiqVimBrokerWorker::Runner < MiqWorker::Runner
self.wait_for_worker_monitor = false

def after_initialize
require 'thread'

Expand Down

0 comments on commit 9875de1

Please sign in to comment.