Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Update xsnap/xsnap-worker argument processing and usage output #52

Open
wants to merge 5 commits into
base: Agoric
Choose a base branch
from

Conversation

gibson042
Copy link

Builds on #51

The following xsnap/xsnap-worker discrepancies are implicitly documented but not addressed:

  • -d <snapshot> (read heap snapshot file and dump a textual representation to stderr) is not supported by xsnap-worker.
  • The option to prefix print(…) output with the current meter count in square brackets is -q for xsnap but -p for xsnap-worker.
  • xsnap supports -s (interpret each non-option operand as the path for a script to load), while xsnap-worker supports -s <size> (set parser buffer size, in kiB (defaults to 8192 = 8_388_608 bytes)).

@gibson042 gibson042 requested review from mhofman and phoddie July 8, 2024 21:50
@gibson042 gibson042 force-pushed the gibson-2024-07-argument-processing-cleanup branch from 8fa709c to 87b170f Compare July 9, 2024 01:47
@phoddie
Copy link
Collaborator

phoddie commented Jul 16, 2024

This all looks reasonable.

(Fair warning: I read the docs and code but didn't confirm things work as described by building and running.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants