fix: Revert "fix: halt-height behavior is not deterministic (#305)" (#…

…337)

* Revert "fix: halt-height behavior is not deterministic (#305)"

This reverts commit 7b8423a.

This commit caused test failures in agoric-sdk.
Reverting to land other changes in agoric-sdk.
We'll restore the change and try to debug the failure
against a smaller diff in the future.

CHANGELOG-Agoric.md

@@ -35,6 +35,12 @@ Ref: https://keepachangelog.com/en/1.0.0/
 
 # Changelog (Agoric fork)
 
+## `v0.45.16-alpha.agoric.2` - 2023-11-08
+
+### Bug Fixes
+
+* (baseapp) [#337](https://github.com/agoric-labs/cosmos-sdk/pull/337) revert #305 which causes test failures in agoric-sdk
+
 ## `v0.45.16-alpha.agoric.1` - 2023-09-22
 
 ### Improvements

baseapp/abci.go

@@ -5,8 +5,10 @@ import (
 	"encoding/json"
 	"errors"
 	"fmt"
+	"os"
 	"sort"
 	"strings"
+	"syscall"
 	"time"
 
 	abcitypes "github.com/cometbft/cometbft/abci/types"
@@ -178,8 +180,6 @@ func (app *BaseApp) BeginBlock(req abci.RequestBeginBlock) (res abci.ResponseBeg
 		))
 	}
 
-	app.checkHalt(req.Header.Height, req.Header.Time)
-
 	if err := app.validateHeight(req); err != nil {
 		panic(err)
 	}
@@ -349,23 +349,6 @@ func (app *BaseApp) DeliverTx(req abci.RequestDeliverTx) (res abci.ResponseDeliv
 	}
 }
 
-// checkHalt checkes if height or time exceeds halt-height or halt-time respectively.
-func (app *BaseApp) checkHalt(height int64, time time.Time) {
-	var halt bool
-	switch {
-	case app.haltHeight > 0 && uint64(height) > app.haltHeight:
-		halt = true
-
-	case app.haltTime > 0 && time.Unix() > int64(app.haltTime):
-		halt = true
-	}
-
-	if halt {
-		app.logger.Info("halt per configuration", "height", app.haltHeight, "time", app.haltTime)
-		panic(errors.New("halt application"))
-	}
-}
-
 // Commit implements the ABCI interface. It will commit all state that exists in
 // the deliver state's multi-store and includes the resulting commit ID in the
 // returned abci.ResponseCommit. Commit will set the check state based on the
@@ -409,6 +392,24 @@ func (app *BaseApp) Commit() abci.ResponseCommit {
 	// empty/reset the deliver state
 	app.deliverState = nil
 
+	var halt bool
+
+	switch {
+	case app.haltHeight > 0 && uint64(header.Height) >= app.haltHeight:
+		halt = true
+
+	case app.haltTime > 0 && header.Time.Unix() >= int64(app.haltTime):
+		halt = true
+	}
+
+	if halt {
+		// Halt the binary and allow Tendermint to receive the ResponseCommit
+		// response with the commit ID hash. This will allow the node to successfully
+		// restart and process blocks assuming the halt configuration has been
+		// reset or moved to a more distant value.
+		app.halt()
+	}
+
 	var snapshotHeight int64
 	if app.snapshotInterval > 0 && uint64(header.Height)%app.snapshotInterval == 0 {
 		snapshotHeight = header.Height
@@ -417,6 +418,28 @@ func (app *BaseApp) Commit() abci.ResponseCommit {
 	return res
 }
 
+// halt attempts to gracefully shutdown the node via SIGINT and SIGTERM falling
+// back on os.Exit if both fail.
+func (app *BaseApp) halt() {
+	app.logger.Info("halting node per configuration", "height", app.haltHeight, "time", app.haltTime)
+
+	p, err := os.FindProcess(os.Getpid())
+	if err == nil {
+		// attempt cascading signals in case SIGINT fails (os dependent)
+		sigIntErr := p.Signal(syscall.SIGINT)
+		sigTermErr := p.Signal(syscall.SIGTERM)
+
+		if sigIntErr == nil || sigTermErr == nil {
+			return
+		}
+	}
+
+	// Resort to exiting immediately if the process could not be found or killed
+	// via SIGINT/SIGTERM signals.
+	app.logger.Info("failed to send SIGINT/SIGTERM; exiting...")
+	os.Exit(0)
+}
+
 // Snapshot takes a snapshot of the current state and prunes any old snapshottypes.
 // It should be started as a goroutine
 func (app *BaseApp) Snapshot(height int64) {

baseapp/abci_test.go

@@ -3,9 +3,7 @@ package baseapp_test
 import (
 	"encoding/json"
 	"fmt"
-	"strings"
 	"testing"
-	"time"
 
 	abci "github.com/cometbft/cometbft/api/cometbft/abci/v1"
 	cmtprotocrypto "github.com/cometbft/cometbft/api/cometbft/crypto/v1"
@@ -2855,59 +2853,3 @@ func (ps *paramStore) Get(_ sdk.Context, key []byte, ptr interface{}) {
 		panic(err)
 	}
 }
-
-func TestABCI_HaltChain(t *testing.T) {
-	logger := defaultLogger()
-	db := dbm.NewMemDB()
-	name := t.Name()
-
-	testCases := []struct {
-		name        string
-		haltHeight  uint64
-		haltTime    uint64
-		blockHeight int64
-		blockTime   int64
-		expHalt     bool
-	}{
-		{"default", 0, 0, 10, 0, false},
-		{"halt-height-edge", 10, 0, 10, 0, false},
-		{"halt-height", 10, 0, 11, 0, true},
-		{"halt-time-edge", 0, 10, 1, 10, false},
-		{"halt-time", 0, 10, 1, 11, true},
-	}
-
-	for _, tc := range testCases {
-		t.Run(tc.name, func(t *testing.T) {
-			defer func() {
-				rec := recover()
-				var err error
-				if rec != nil {
-					err = rec.(error)
-				}
-				if !tc.expHalt {
-					require.NoError(t, err)
-				} else {
-					require.Error(t, err)
-					require.True(t, strings.HasPrefix(err.Error(), "halt application"))
-				}
-			}()
-
-			app := NewBaseApp(
-				name, logger, db, nil,
-				SetHaltHeight(tc.haltHeight),
-				SetHaltTime(tc.haltTime),
-			)
-
-			app.InitChain(abci.RequestInitChain{
-				InitialHeight: tc.blockHeight,
-			})
-
-			app.BeginBlock(abci.RequestBeginBlock{
-				Header: tmproto.Header{
-					Height: tc.blockHeight,
-					Time:   time.Unix(tc.blockTime, 0),
-				},
-			})
-		})
-	}
-}