feat(postalSvc): deliver payment using address #2
Conversation
Agoric/agoric-sdk#8547 2023-11-17 19:10 0040bea4a feat: postalSvc contract forwards payments using namesByAddress
- tweak order in test result (again XXX) - update imports to work outside zoe pkg - replace asset() function with assets record - install bundles with fake vat admin rather than intercepting E(zoe).installbundleID() - no need for wrapZoe - hoist bootstrap() out of test(...)
There was a problem hiding this comment.
Tested using node 18.18.2 and agoric 0.22.0-u13.0.
Working for me with these 2 changes in #3:
| ]); | ||
| const { instance } = await E(zoe).startInstance( | ||
| installation, | ||
| { IST, Invitation }, |
There was a problem hiding this comment.
creatorFacet method to add issuers?
governed API to add issuers?
#8547
It seems like this may be a common requirement. I wonder if it's possible for a contract to have a dynamic list of issuers from a nameHub. Could maybe be added to StandardTerms from zoe or specified in the startInstance function.
There was a problem hiding this comment.
I also wonder if this is a better approach here, saving issuers on the fly. Tying postalSvc to a NameHub like agoricNames might preclude wider usage.
There was a problem hiding this comment.
Contracts usually add issuers that they are confident that they can rely on, so letting clients unilaterally add issuers is usually a no-no. But in this case, maybe it's ok, since we're just relaying assets that the parties choose to use?
Does this contract belong here?
It's not really partitioning anything.
It works around
once so that clients don't have to. (though currently the way it does that might have some durability issues).
It does provide a familiar contract-based API to
namesByAddress. And makesE(depositFacet).receive()available via smart-wallet style offers.Maybe that last one justifies adding it here. Maybe putting a smart-wallet face on something is also in scope for this repo.
refs: