Speed up label checking by making binary smaller #65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit removes the DWARF debugging information[1], resulting in the Docker image size shrinking from 4.76MB to 2.88MB. Decided not to try to also turn off generation of the Go symbol table using the `-s` flag, as: 1. the GOFLAGS functionality currently only allows 1 ldflag to be set[2] (NB this may be fixed in Go 1.15[3]) 2. The improvements to the binary size in Go 1.15 [4] mean that the `-s` flag will no longer really do anything[5] Will also try shrinking the binary size further using upx[6] in a separate pull request. [1] https://stackoverflow.com/a/22276273 [2] golang/go#38522 [3] golang/go#26849 (comment) [4] See #64 [5] https://twitter.com/bradfitz/status/1256989624590712834 [6] https://upx.github.io/
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit removes the DWARF debugging information[1], resulting in the
Docker image size shrinking from 4.76MB to 2.88MB.
Decided not to try to also turn off generation of the Go symbol table
using the
-sflag, as:(NB this may be fixed in Go 1.15[3])
-sflag will no longer really do anything[5]
Will also try shrinking the binary size further using upx[6] in a
separate pull request.
[1] https://stackoverflow.com/a/22276273
[2] golang/go#38522
[3] golang/go#26849 (comment)
[4] See #64
[5] https://twitter.com/bradfitz/status/1256989624590712834
[6] https://upx.github.io/