Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Debian/Ubuntu support #88
base: master
Are you sure you want to change the base?
Debian/Ubuntu support #88
Changes from 15 commits
9c6308d
0ef1752
0482ba2
e31f138
a7c8b8d
d4e4bbe
6614340
8cc6938
db3d82d
a7985a3
611e170
44a78be
25c27cd
341d856
76459a9
cd7c08a
393b25d
301f1c1
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
This file was deleted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess you are aware this script needs rewrite as right now it's a copy-paste hybrid from two projects.
I think you have to start from the Arch version then cut-out everything that isn't related to generating secrets (nfc, luks options,trails,timeout, etc.). End result should resemble what debian version does (check if yubikey is available, ask for user secret or read it from config, send to yubikey, print response) but it needs to be consistent with arch version code syntax.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well, this took a little longer than I thought, but I just finished modifying the Arch Linux version to work with Debian/Ubuntu. I left in the commented out lines from the original for now so it's easier to see what's different between the Arch and Debian versions. I confirmed that it works for both when the Yubikey is present and when there is no Yubikey present.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see you still left some things like nfc (there is no support for it in debian), trials/timeouts (do the work?) and unused variables:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just removed the commented sections of code, along with the NFC code and unused variables.
As far as the trials and timeout goes, I have confirmed that they work. After the given number of trials, the prompt no longer accepts challenges or passphrases. After the given timeout, the prompt switches from asking for the challenge to asking for a passphrase.
The only issue I've come across is that I was unable to get the messages working. If there is no YubiKey present, the message saying
> Waiting x for YubiKey
does not appear. Also, I believe the message sayingRemember to touch the device if necessary.
does not appear.Other than the lack of messages, everything else appears to be working correctly.