[Micledore] backport patch: linux-raspberrypi: stop setting powersave as the default CPU governor #1243
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* The defconfigs from the RPi Kernel set `powersave` as the default CPU governor, which is a bad idea as that reduces performance by setting the CPU frequency to the minimum one. * In case of a Yocto build user-space is not configured by default to change the CPU governor, so `powersave` will remain the CPU governor and it will slow down everything. * I submitted a fix for those defconfigs to upstream here: raspberrypi/linux#5666 However, we shouldn't wait until that is accepted and backported to all the stable branches (if ever is). * This patch unsets the selection of `powersave` as the default CPU governor. * Then the CPU governor that will be selected as default after this patch will be the Linux's default one that is either `ondemand` or `schedutil` depending on the Kernel version. Signed-off-by: Carlos Alberto Lopez Perez <[email protected]>
agherzan
approved these changes
Nov 14, 2023
|
Thanks! But I don't have commit/push rights, need someone else to merge it for me |
|
Yes. I will deal with that - I'm just waiting for the CI to finish. |
webkit-commit-queue
pushed a commit
to clopez/WebKit
that referenced
this pull request
Dec 14, 2023
…change CPU frequency governor for RPis https://bugs.webkit.org/show_bug.cgi?id=266353 Reviewed by Philippe Normand. This updates the Yocto layers used for the RPi build with the following major changes: - meta-webkit: include libbacktrace and libportal into the base build. libbacktrace is required by the default build of WPE now and libportal is required by Cog since bug 266351 - meta-raspberrypi: stop setting "powersave" as the default CPU frequency governor and use "schedutil" instead. This will likely mean a big change in the performance results of all tests. See agherzan/meta-raspberrypi#1243 for context. - poky, meta-openembedded: just update to the last version of the Mickledore branch - backport a change landed in meta-openembedded master to the Mickledore branch that updates libbacktrace to allow building it on riscv64. * Tools/yocto/meta-openembedded_backport-libbacktrace-patch-to-mickledore-branch.patch: Added. * Tools/yocto/riscv/manifest.xml: * Tools/yocto/rpi/manifest.xml: * Tools/yocto/targets.conf: Canonical link: https://commits.webkit.org/272030@main
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This cherry-picks 0a4a68d from master into Mickledore branch