Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add remaining constraints in aggchain proof #84

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

hadjiszs
Copy link
Contributor

@hadjiszs hadjiszs commented Mar 4, 2025

Description

  • Add verification of the l1 head
  • Hardcode the hash of the aggregation vkey directly in the aggchain proof program
  • Adapt for the optimisticMode
    • Align the aggchain_params expression
    • Add the case signature verification of the fep public values

Spin off in another PR (#89)

  • Compute the hash chain global index from the prover inputs
  • Add the "delete" hashChains
  • Put the right static calls to retrieve the new and prev hash chain global index

PR Checklist:

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added or updated tests that comprehensively prove my change is effective or that my feature works

@hadjiszs hadjiszs marked this pull request as ready for review March 7, 2025 10:44
@hadjiszs hadjiszs requested a review from a team as a code owner March 7, 2025 10:44
@hadjiszs hadjiszs requested review from iljakuklic and atanmarko March 7, 2025 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant