Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: e2ebridge_getClaims #243

Merged
merged 14 commits into from
Mar 3, 2025
Merged

test: e2ebridge_getClaims #243

merged 14 commits into from
Mar 3, 2025

Conversation

rachit77
Copy link
Contributor

Description

Added bats e2e forbridge_getClaims endpoint

Comment on lines 156 to 164
echo "------- bridge_getClaims API testcase --------"
run get_claims "$aggkit_node_url" "$l1_rpc_network_id" "$global_index" 10 15
assert_success

local origin_network="$(echo "$output" | jq -r '.origin_network')"
local destination_network="$(echo "$output" | jq -r '.destination_network')"
assert_equal "$l1_rpc_network_id" "$origin_network"
assert_equal "$l2_rpc_network_id" "$destination_network"
echo "🚀🚀 bridge_getClaims API testcase passed" >&3
Copy link
Contributor

@Stefan-Ethernal Stefan-Ethernal Feb 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just thinking out loud and want to discuss with you:
should we, at least for now, assert both bridge_getBridges and bridge_getClaims in a single e2e test (for example the Native gas token deposit to WETH one).

Eventually, probably we can make some helper functions and assert bridges and claims in each test (if I'm not mistaken, we are going to do this anyway once we substitute the zkevm-bridge-service with the aggkit one, so no rush with this).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will move bridge_getClaims assertions to Native gas token deposit to WETH where we already have assertions for bridges

@Stefan-Ethernal Stefan-Ethernal force-pushed the claims-test branch 3 times, most recently from 5960387 to 584a44a Compare March 2, 2025 11:07
Copy link

sonarqubecloud bot commented Mar 3, 2025

@rachit77 rachit77 merged commit b34f4e8 into feat/new-bridge-service Mar 3, 2025
19 checks passed
@rachit77 rachit77 deleted the claims-test branch March 3, 2025 13:23
Stefan-Ethernal added a commit that referenced this pull request Mar 3, 2025
Co-authored-by: Stefan Negovanović <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants