-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: e2ebridge_getClaims
#243
Conversation
a01a61f
to
b404069
Compare
test/bats/pp/bridge-e2e.bats
Outdated
echo "------- bridge_getClaims API testcase --------" | ||
run get_claims "$aggkit_node_url" "$l1_rpc_network_id" "$global_index" 10 15 | ||
assert_success | ||
|
||
local origin_network="$(echo "$output" | jq -r '.origin_network')" | ||
local destination_network="$(echo "$output" | jq -r '.destination_network')" | ||
assert_equal "$l1_rpc_network_id" "$origin_network" | ||
assert_equal "$l2_rpc_network_id" "$destination_network" | ||
echo "🚀🚀 bridge_getClaims API testcase passed" >&3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just thinking out loud and want to discuss with you:
should we, at least for now, assert both bridge_getBridges
and bridge_getClaims
in a single e2e test (for example the Native gas token deposit to WETH
one).
Eventually, probably we can make some helper functions and assert bridges and claims in each test (if I'm not mistaken, we are going to do this anyway once we substitute the zkevm-bridge-service
with the aggkit one, so no rush with this).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will move bridge_getClaims
assertions to Native gas token deposit to WETH
where we already have assertions for bridges
7a80e0d
to
6eed059
Compare
4b0feb5
to
8783303
Compare
5960387
to
584a44a
Compare
|
Co-authored-by: Stefan Negovanović <[email protected]>
Description
Added bats e2e for
bridge_getClaims
endpoint