Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AggKit UX #27

Open
4 tasks
arnaubennassar opened this issue Dec 11, 2024 · 0 comments
Open
4 tasks

AggKit UX #27

arnaubennassar opened this issue Dec 11, 2024 · 0 comments
Assignees
@arnaubennassar
Labels
cli & config epic super issue containing sub issues

Comments

@arnaubennassar
Copy link
Collaborator

arnaubennassar commented Dec 11, 2024 •
edited
Loading

Evaluate current status of CLI & Config, explore how future integrations work and propose a solution. This should cover:

  • Docs
  • Updates: how we communicate the changes on the integration
  • CI checks
  • Simplicity: it should be easy!

A discussion should be created with a proposal. Once approved, open issues and link them to this issue
@arnaubennassar arnaubennassar self-assigned this Dec 11, 2024
@arnaubennassar arnaubennassar changed the title CDK UX AggKit UX Dec 11, 2024
@arnaubennassar arnaubennassar added cli & config epic super issue containing sub issues labels Dec 11, 2024
Stefan-Ethernal added a commit that referenced this issue Dec 24, 2024
@arnaubennassar @Stefan-Ethernal @joanestebanr
Feature/exittree (#27)
0f98a37 
* implementation completed, missing tests

* WIP

* WIP

* WIP

* sync refactor

* decouple sync processors from EVM

* Add CLI for aggOracle

* WIP

* wip

* WIP

* start reorg detector

* fix docker

* pass test with docker

* add TODO

* go mod tidy

* Implement base addLeaf

* pass test vectors

* fix UT

* Add PR review suggestions from Stefan-Ethernal

* fix UTs

* Add PR review suggestions from Stefan-Ethernal

* fix datacommittee_test deploying proxy contract

* fix UTs

* WIP

* WIP

* abstract tree

* Fix UTs

* Add PR review suggestions from joanestebanr

* Fix evmdownloader problems

* refactor tree add and rollback to be atomic

* simplify l1infotree

* implementation done, test WIP

* pass E2E test

* remove outdated coment

* make test shorter

* Add coments

* Apply requests from Stefan-Ethernal and goran-ethernal

* increase sleep to pass UT

* reduce test iterations

---------

Co-authored-by: Stefan Negovanović <[email protected]>
Co-authored-by: joanestebanr <[email protected]>
Stefan-Ethernal added a commit that referenced this issue Dec 24, 2024
@arnaubennassar @Stefan-Ethernal @joanestebanr
Feature/exittree (#27)
94965ee 
* implementation completed, missing tests

* WIP

* WIP

* WIP

* sync refactor

* decouple sync processors from EVM

* Add CLI for aggOracle

* WIP

* wip

* WIP

* start reorg detector

* fix docker

* pass test with docker

* add TODO

* go mod tidy

* Implement base addLeaf

* pass test vectors

* fix UT

* Add PR review suggestions from Stefan-Ethernal

* fix UTs

* Add PR review suggestions from Stefan-Ethernal

* fix datacommittee_test deploying proxy contract

* fix UTs

* WIP

* WIP

* abstract tree

* Fix UTs

* Add PR review suggestions from joanestebanr

* Fix evmdownloader problems

* refactor tree add and rollback to be atomic

* simplify l1infotree

* implementation done, test WIP

* pass E2E test

* remove outdated coment

* make test shorter

* Add coments

* Apply requests from Stefan-Ethernal and goran-ethernal

* increase sleep to pass UT

* reduce test iterations

---------

Co-authored-by: Stefan Negovanović <[email protected]>
Co-authored-by: joanestebanr <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@arnaubennassar arnaubennassar

Labels
cli & config epic super issue containing sub issues
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@arnaubennassar