New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make min_scraped_sites a ratio of available sites #115

Closed

kongzii wants to merge 1 commit into main from peter/sites

Collaborator

kongzii commented Oct 14, 2024

No description provided.


          Make min_scraped_sites a ratio of available sites

d743b18

evangriffiths reviewed

View reviewed changes

Collaborator

evangriffiths left a comment

I think min_scraped_sites is useful for ensuring two things:

the number of sites returned from tavily search is long enough that we have enough sources for a 'good' research report
that the scraping of these sources was successful

This change keeps (2), but loses (1). I would prefer either

try-excepting research wherever it's called (maybe we could make a InsufficientSourceMaterialForResearchError exception class to make it easier to catch), or
returning Research | None.

kongzii closed this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet