Update PMAT and necessary changes for new langchain and small changes to be compatible with PMA #103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -10,6 +11,9 @@ | |||
| from prediction_prophet.functions.search import search | |||
| from pydantic.types import SecretStr | |||
|
|
|||
| if t.TYPE_CHECKING: | |||
| from loguru import Logger | |||
There was a problem hiding this comment.
What is this change for? It looks below like it is still always using logging.Logger below
There was a problem hiding this comment.
I added the loguru's Logger below into accepted types, because in PMAT/PMA we use loguru, so we can pass it there without mypy complaining.
logger: t.Union[logging.Logger, "Logger"] = logging.getLogger()
There was a problem hiding this comment.
And idk why logging.Logger | "Logger" doesn't work in Python, so we need to use the old-school Union[logging.Logger, "Logger"].
There was a problem hiding this comment.
Ahh, so we can use prophet's research in PMA? Makes sense!
evangriffiths
approved these changes
Jul 16, 2024
kongzii
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.