Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve configure script #100

Merged
merged 23 commits into from
Nov 1, 2020
Merged

Improve configure script #100

merged 23 commits into from
Nov 1, 2020

Conversation

sebschrader
Copy link
Member

  • Improve ordering
    • Sort different items properly
    • Sort generated constants
    • Define variables before they are used
  • Always use bash
  • Use bash safe mode flags (set -euo pipefail)
  • Improve headings/decorations
  • Check for unsubstituted variables
  • Improve error messages
  • Add docstring for generated constants module
  • Fix missing do edit message in constants module file
  • Save configure flags and add print them with -V/--version

@sebschrader
Change comment header decoration
d863105
@sebschrader
Print configure options and copyright notice
9ca9ca9
@sebschrader
Move NULL variable assignment to top
9f250c8
@sebschrader
Set SHELL to bash at top of Makefile
3764393 
Otherwise preceding shell invocations will not use bash.
@sebschrader
Use bash conditional syntax
c7fc0f3
@sebschrader
Set conservative shell error flags
93b72ec
@sebschrader
Strip arguments
25a3885
@sebschrader
Fix underline length
9cfd7c3
@sebschrader
Implement require_program with add_substitution
4aba24b
@sebschrader
Add function thats checks shell result
dca965c 
Add add_shell_substitution function, that checks for non-zero exit
status and non-empty output of a shell call.
@sebschrader
Use https scheme for PACKAGE_URL
990ae06
@sebschrader
Fix shell redirection
8ca3200
@sebschrader
Ensure no unsubstituted variables exists
145af28
@sebschrader
Add PATH in error message
50a8ae8
@sebschrader
Sort substitutions in constants module
26b6bf2
@sebschrader
Put targets under a section
a129c30
@sebschrader
Specify .PHONY after each target
c7799b6
@sebschrader
Skip variables if clean is only goal
0971483
@sebschrader
Sort tmpfile entries
e2f47c5
@sebschrader
Sort CONFIGURE_FILES
81bc3ff
@sebschrader
Sort derived paths
066b91b
@sebschrader
Put name constants into own section
63056f0
@sebschrader
Add docstring to generated constants module
57b93ce
@sebschrader sebschrader self-assigned this Nov 1, 2020
@sebschrader sebschrader added this to the 0.5 milestone Nov 1, 2020
@sebschrader sebschrader merged commit 4864bdf into master Nov 1, 2020
@sebschrader sebschrader deleted the feature/configure-improvements branch July 6, 2022 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@sebschrader sebschrader

Labels
enhancement hacktoberfest-accepted
Projects
None yet
Milestone
0.5
Development

Successfully merging this pull request may close these issues.
1 participant
@sebschrader