Merge pull request #51 from agatapst/native-filters/sort-select-input

chore: Sort select inputs in Filter Config modal alphabetically
agatapst · Dec 4, 2020 · 6592543 · 6592543
2 parents c529840 + d52a419
commit 6592543
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 2 deletions.
diff --git a/superset-frontend/src/components/SupersetResourceSelect.tsx b/superset-frontend/src/components/SupersetResourceSelect.tsx
@@ -78,7 +78,9 @@ export default function SupersetResourceSelect<T = unknown, V = string>({
       endpoint: `/api/v1/${resource}/?q=${query}`,
     }).then(
       response => {
-        return response.json.result.map(transformItem);
+        return response.json.result
+          .map(transformItem)
+          .sort((a: Value<V>, b: Value<V>) => a.label.localeCompare(b.label));
       },
       async badResponse => {
         const { error, message } = await getClientErrorObject(badResponse);

diff --git a/superset-frontend/src/dashboard/components/nativeFilters/ColumnSelect.tsx b/superset-frontend/src/dashboard/components/nativeFilters/ColumnSelect.tsx
@@ -65,7 +65,9 @@ export function ColumnSelect({
       endpoint: `/api/v1/dataset/${datasetId}`,
     }).then(
       ({ json: { result } }) => {
-        return result.columns.map((col: any) => col.column_name);
+        return result.columns
+          .map((col: any) => col.column_name)
+          .sort((a: string, b: string) => a.localeCompare(b));
       },
       async badResponse => {
         const { error, message } = await getClientErrorObject(badResponse);