Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated hand-control to emit events that are consistent with the documentation (fixes aframevr#4883) #4887

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Clicky02
Copy link
Contributor

Description: Changes the EVENTS object and getGestureEventName function to emit events that are consistent with the documentation found at https://aframe.io/docs/1.2.0/components/hand-controls.html#events. Previously, the only events emitted were gripclose, gripopen, pistolstart, pistolend, pointingstart, and pointingend. Additionally, pistolstart and pistolend were emitted when thumbup and thumbdown should have been emitted. See #4883 for more detail.

Changes proposed:

  • Have the pistol events be emitted with the pointThumb animation.
  • Have the thumb events be emitted with the thumbUp animation.
  • Have the point events be emitted with the hold animation.
  • Change the suffixes for the grip events to down/up.
  • Add up/down as the suffixes for the thumb events

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants