Updated hand-control to emit events that are consistent with the documentation (fixes aframevr#4883) #4887
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: Changes the EVENTS object and getGestureEventName function to emit events that are consistent with the documentation found at https://aframe.io/docs/1.2.0/components/hand-controls.html#events. Previously, the only events emitted were gripclose, gripopen, pistolstart, pistolend, pointingstart, and pointingend. Additionally, pistolstart and pistolend were emitted when thumbup and thumbdown should have been emitted. See #4883 for more detail.
Changes proposed: