-
Notifications
You must be signed in to change notification settings - Fork 200
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
A-Painter on AFrame 1.5 - Various fixes #278
Open
Elettrotecnica
wants to merge
15
commits into
aframevr:master
Choose a base branch
from
Elettrotecnica:on-aframe-1-5
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
in particular, to get aframevr/aframe#5415
…lor the vertices of our strokes
Fixes warnings in the console such as: core:component:warn Unknown property `height` for component `geometry`.
Fixes warnings in the console
…s not depend on the device model
…he controller element they are relevant for Currently, only oculus controllers are affected
…ng when their tooltip fades
One additional fix: I have refactored the appearing/disappearing logics of the tooltips so that the lines will also disappear when they fade away. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dear maintainers,
in this pull request I submit to your judgment a few fixes and improvements to a-painter that make it work better on AFrame 1.5.
I could only test these changes on Oculus/Meta devices, but I believe they should not be harmful to other headsets.
I am also not sure how to test the exporting of drawings, but I could have a look at that as well with some direction.Saving a drawing and loading it works as wellI have structured the commits so that each one represents a single fix or improvement. Hopefully, this will make reviewing the changes easier.
Short summary of the fixes:
Short summary of improvements: