I get a white screen when i activate this plugin

[roger2014jr]

I'm using the latest WordPress with a multi-site install, Now I'm stuck and have to figure out how to uninstall this plugin manually

[afragen]

Try adding define( ‘WP_DEBUG’, true ); in your wp-config.php file to see where the error is.

[picasso]

PHP Fatal error: Allowed memory size of 536870912 bytes exhausted (tried to allocate 20480 bytes) in /wp-content/plugins/github-updater/src/Singleton.php on line 39, referer: /wp-admin/update-core.php

I've got this error when updated github-updater from version 7.3.1.19 to version 7.5.0.7

[afragen]

500 internal server errors are often difficult to figure out. https://www.google.com/search?q=500+internal+server+error

My test site have 768M allocated to memory. Most of these errors are related to htaccess files.

[afragen]

Line 39 of Singleton is a call to the PHP function debug_backtrace().

I’m looking at ways to limit this but likely won’t be able to test until tonight.

[afragen]

For now you can comment out https://github.com/afragen/github-updater/blob/develop/src/Singleton.php#L39 until I can fix and test. This will likely cause several non-fatal PHP errors.

[reddog]

Can confirm I also get the same error with a fresh install of WordPress 4.9.4 on Ubuntu 16.04.

Removing the github-updater-develop folder from plugins (I downloaded the zip from https://github.com/afragen/github-updater which appears to auto-download the develop branch), and then installing the 7.5.0 release from https://github.com/afragen/github-updater/releases/tag/7.5.0 , it looks like all is okay.

[afragen]

Thanks @reddog. I believe the debug_backtrace() was a conditional call in the master branch but I changed to make it happen all the time. I’m working on a fix.

[afragen]

Update to latest develop branch and let me know if the memory issue persists. Thanks.

[teolaz]

Same error with last develop branch version (line 41), switched to 7.5.0 as suggested by @reddog and now it's working again...

[afragen]

So the problem is that there is really no difference in Singleton.php from the develop branch to 7.5.0

I realize that this is where the error is firing but can people share anything else that they did to there installations in the same timeframe?

Does this issue persist in a local installation?

[afragen]

Can people provide server details. PHP version, WP version, PHP memory available?

[afragen]

Is there anything new? I’ve been unable to replicate this issue, does it still exist?

[tomkenkel]

Still exists. WP 4.9.4; Ubuntu 16.04 LTS; PHP 7.0.27; PHP Memory Limit 256MB.

[afragen]

Can we all test in a local environment. I’d like to try and replicate this but haven’t been able to.

Test using default theme and only with the GitHub Updater plugin active.

[tomkenkel]

Using scotchbox. New WP install; twentyseventeen theme; GitHub Updater the only active plugin.

[afragen]

Can you rename github-updater-develop to github-updater?

[afragen]

Are there any mu-plugins?

[afragen]

@tomkenkel does switching to v7.5.0 work for you?

[tomkenkel]

I renamed the directory. No fix.
No mu-plugins. Full plugin list is Akismet, Hello Dolly, and GitHub Updater. Only GHU is active.
7.5.0 works as expected. All previous versions of this plugin have been great. Thank you for making it!

[afragen]

@tomkenkel I have to say I don’t really understand why 7.5.0 works but develop doesn’t. The Singleton class isn’t significantly different between the 2 versions.

[tomkenkel]

I’m not good at PHP, but I don't think it's the class. Replacing the Singleton class in develop with the class from 7.5.0 creates a different error:
“Allowed memory size of 268435456 bytes exhausted (tried to allocate 20480 bytes)…”

[afragen]

The odd thing is there’s not a significant amount of difference in the develop branch.

Can you add the following in wp-config.php and check the debug.log in wp-content?

define( 'WP_DEBUG', true );
define( 'WP_DEBUG_LOG', true );
define( 'WP_DEBUG_DISPLAY', false );

[afragen]

Interesting, a new error. Can you change the timeout? https://www.fdgweb.com/increase-php-timeout-values-apache-ngnix/

And I have zero idea why there would be a timeout here. Not even hitting an API. You might try adding the filter to bypass wp-cron and eliminate that as an issue.

add_filter( 'github_updater_disable_wpcron', '__return_true' );

[tomkenkel]

Longer timeout

[04-Mar-2018 23:05:18 UTC] PHP Fatal error: Maximum execution time of 240 seconds exceeded in /var/www/public/site/wp-content/plugins/github-updater/src/Singleton.php on line 41

[04-Mar-2018 23:06:41 UTC] PHP Fatal error: Maximum execution time of 240 seconds exceeded in /var/www/public/site/wp-content/plugins/github-updater/src/Singleton.php on line 42

[04-Mar-2018 23:10:08 UTC] PHP Fatal error: Maximum execution time of 240 seconds exceeded in /var/www/public/site/wp-content/plugins/github-updater-develop/src/Singleton.php on line 41

[afragen]

Set the timeout for 600, humor me.

Also, if you could dump the $backtrace variable from that line to a gist, that would help.

[afragen]

Another thing to try is changing the line to the following.

$backtrace = debug_backtrace( $limit = 2 );

[afragen]

Odd that a standard PHP function would timeout.

[afragen]

Can you try the branch no-backtrace and let me know if that works?

[tomkenkel]

Different error

[06-Mar-2018 13:18:46 UTC] PHP Fatal error: Allowed memory size of 805306368 bytes exhausted (tried to allocate 262144 bytes) in /var/www/public/site/wp-includes/option.php on line 1186 [06-Mar-2018 13:18:47 UTC] PHP Fatal error: Allowed memory size of 805306368 bytes exhausted (tried to allocate 262144 bytes) in /var/www/public/site/wp-includes/load.php on line 679

This was run on Scotchbox’s recently updated server stack. I can try tonight with the stack I used when we started.

[afragen]

Is there more in the error logs? This error doesn't seem to trace back to GitHub Updater directly, does it?

[afragen]

I think I may have found an fixed this error. I think it may be related to #656

Please test and let me know.

[tomkenkel]

Installs and activates as expected. I was able to install and activate a theme from GitHub. I haven’t tried updating the theme. I started getting the cron warning below after updating Scotchbox. It’s always something.

Thanks for your persistence!

[afragen]

That’s just a warning that WP-Cron hasn’t run in over 24 hours. If this persists it may mean that something in the server setup is interfering with how WP-Cron runs and you might need to create an actual cron job. Look at the wiki regarding background processing.

[afragen]

@roger2014jr @teolaz @reddog @picasso please let me know if this issue is fixed for you. Thanks.

[afragen]

@tomkenkel you can also turn off background processing with a filter to see if the issue is WP-Cron only.

add_filter( 'github_updater_disable_wpcron', '__return_true' );

[teolaz]

@afragen updated to 7.5.0, cannot get again the same error on different sites :S

[afragen]

The error was on the develop branch, not the release.

[afragen]

This is fixed in latest develop branch. I had inadvertently created an infinite loop. 🤦‍♂️