Add method to retrieve parcel documents #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because this endpoints returns binary data representing a pdf/zpl/png, the Request method could not be used in its current form. Therefore I split the method into two methods, one for creating a new request (NewRequest) and one for validating the response from the api (ValidateResponse), while keeping Request backwards compatible. - add NewRequest function - add ValidateResponse function - add Document struct - add GetDocument method to parcel.Client
|
Can someone please have a look at this PR? |
|
Looks good! Thanks! 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR add a new method to retrieve parcel documents. Because the endpoint https://api.sendcloud.dev/docs/sendcloud-public-api/parcel-documents/operations/get-a-parcel-document returns binary data representing a pdf/zpl/png, the Request method could not be used in its current form. Therefore I split the method into two methods, one for creating a new request (NewRequest) and one for validating the response from the api (ValidateResponse), while keeping Request backwards compatible.