Expose mesh indices in intersection data #77
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @aevyrie, is this PR something you'd consider accepting? |
|
Yes, but I need some free time to review this. I'm not sure how much data we should stuff in this struct, or just return the indices and make the user look up things like vertex positions and normals. |
|
No problem. I'm using this data in tandem with bevy_mod_picking. I was looking at the other backends and saw that rapier exposes the data using a struct called feature id. Maybe we could figure out the best way to expose the intersection data from rapier in the HitData and then work backwards for this backend? |
|
Just saw this PR. I have opened a similar PR which exposes just the indices. See: #107 |
|
Closed in favor of #103. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: I also ran
cargo fmt, which reformattedsrc/primitives.rssince it used carriage returns.