feat: Dex Trades per Token #876
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
janmichek
force-pushed
the
dex-trades-token
branch
from
00f6474
to
7ebfae4
Compare
janmichek
force-pushed
the
dex-trades-token
branch
from
478d2d9
to
b75faf8
Compare
|
Regression, waiting for aeternity/ae_mdw#1815 (comment) to be resolved |
janmichek
force-pushed
the
dex-trades-token
branch
from
c2611a7
to
5488339
Compare
janmichek
commented
Nov 21, 2024
| @@ -9,10 +9,10 @@ | |||
| </template> | |||
|
|
|||
| <script setup> | |||
| import { useAppStore } from '@/stores/app' | |||
| import { useUiStore } from '@/stores/ui' | |||
There was a problem hiding this comment.
not related to the feature, renamed confusing store name. App is too general
janmichek
commented
Nov 21, 2024
| @@ -13,8 +13,7 @@ export const useDexStore = defineStore('dex', () => { | |||
| return 1 | |||
| } | |||
|
|
|||
| const { data } = await axios.get(`${DEX_BACKEND_URL}/pairs/swap-routes/${tokenId}/${AE_TOKEN_ID}`) | |||
|
|
|||
| const { data } = await axios.get(`${DEX_BACKEND_URL}/swap-routes/${tokenId}/${AE_TOKEN_ID}`) | |||
There was a problem hiding this comment.
dex changed link just today
Liubov-crypto
suggested changes
Nov 25, 2024
There was a problem hiding this comment.
In general LGTM.
But I have a question regarding test tokens. For example if nobody was trading token there would be no trade activity. When I open Trades tab the page will be in endless loading:
https://pr-876-aescan-testnet.stg.service.aepps.com/tokens/ct_25e9fYcVxp8qHhiHE3ZZKv1qsRZ8knvJefcUmTchZi33WANgt7?type=trades
2024-11-25.5.36.51.mov
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
resolves #522
Demo
Checklist: