Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: use argon2-browser instead of libsodium-wrappers-sumo #1208

Merged
merged 5 commits into from
Feb 7, 2022

Conversation

davidyuk
Copy link
Member

@davidyuk davidyuk commented Jun 5, 2021

depends on antelle/argon2-browser#66

before:

1.8M Feb  7 10:25 aepp-sdk.browser-script.js
838B Feb  7 10:19 aepp-sdk.browser-script.js.LICENSE.txt
5.8M Feb  7 10:25 aepp-sdk.browser-script.js.map
146K Feb  7 10:25 aepp-sdk.browser.js
581K Feb  7 10:25 aepp-sdk.browser.js.map
142K Feb  7 10:25 aepp-sdk.js
580K Feb  7 10:25 aepp-sdk.js.map

after:

723K Feb  7 10:46 aepp-sdk.browser-script.js
838B Feb  7 10:19 aepp-sdk.browser-script.js.LICENSE.txt
2.8M Feb  7 10:46 aepp-sdk.browser-script.js.map
146K Feb  7 10:49 aepp-sdk.browser.js
581K Feb  7 10:49 aepp-sdk.browser.js.map
142K Feb  7 10:49 aepp-sdk.js
580K Feb  7 10:49 aepp-sdk.js.map

@davidyuk davidyuk requested a review from mradkov June 5, 2021 19:47
@codecov
Copy link

codecov bot commented Jun 5, 2021

Codecov Report

Merging #1208 (2cc1db3) into develop (d3434d8) will decrease coverage by 0.10%.
The diff coverage is 100.00%.

❗ Current head 2cc1db3 differs from pull request most recent head 5d79548. Consider uploading reports for the commit 5d79548 to get more accurate results

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1208      +/-   ##
===========================================
- Coverage    69.58%   69.48%   -0.11%     
===========================================
  Files           22       22              
  Lines         1233     1232       -1     
  Branches        40       40              
===========================================
- Hits           858      856       -2     
- Misses         364      365       +1     
  Partials        11       11              
Impacted Files Coverage Δ
src/utils/keystore.js 94.54% <100.00%> (-1.89%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d3434d8...5d79548. Read the comment docs.

@davidyuk davidyuk force-pushed the feature/argon-browser branch 3 times, most recently from 6c00d90 to e06f9fc Compare June 5, 2021 20:50
@marc0olo marc0olo added this to the Cleanup / Finish old PRs milestone Oct 11, 2021
@davidyuk davidyuk modified the milestones: Revisit and comment old PRs, Reduce bundle size Dec 29, 2021
@davidyuk davidyuk modified the milestones: Reduce bundle size, Revisit and comment old PRs Dec 29, 2021
Copy link
Collaborator

@thepiwo thepiwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fine if it works

@davidyuk davidyuk force-pushed the feature/argon-browser branch 2 times, most recently from cd22016 to 21c17aa Compare February 7, 2022 08:15
@davidyuk davidyuk marked this pull request as ready for review February 7, 2022 08:27
@davidyuk davidyuk merged commit e54898c into develop Feb 7, 2022
@davidyuk davidyuk deleted the feature/argon-browser branch February 7, 2022 08:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants