Merge pull request #12 from crevete/xml_encoding_fix

Enforce XML document encoding to UTF-8

lib/minitest/junit.rb

@@ -28,7 +28,7 @@ def record(result)
       end
 
       def report
-        doc = Ox::Document.new(:version => '1.0')
+        doc = Ox::Document.new(version: '1.0', encoding: 'UTF-8')
         instruct = Ox::Instruct.new(:xml)
         instruct[:version] = '1.0'
         instruct[:encoding] = 'UTF-8'
@@ -89,10 +89,6 @@ def working_directory
         @working_directory ||= Dir.getwd
       end
 
-      def failure_message(result)
-        "#{result.klass}##{result.name}: #{result.failure}"
-      end
-
       def relative_to_cwd(path)
         path.sub(working_directory, '.')
       end

test/reporter_test.rb

@@ -19,6 +19,18 @@ def test_no_tests_generates_an_empty_suite
     )
   end
 
+  # NOTE: This test will generate a temp file: "test/tmp/report.xml"
+  def test_encoding
+    # Enforce File.external_encoding to UTF-8 to ensure that ASCII character will be correctly converted to UTF-8
+    file = File.new('test/tmp/report.xml', 'w:UTF-8')
+    reporter = Minitest::Junit::Reporter.new file, { hostname: '‹foo›' }
+    reporter.start
+    reporter.report
+    file.close
+
+    assert_match(/hostname="‹foo›"/, File.new('test/tmp/report.xml', 'r:UTF-8').read)
+  end
+
   def test_formats_each_successful_result_with_a_formatter
     reporter = create_reporter