Add optional strict argument to Type.is_valid_value
#995
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brandonwillard
added
bug
brandonwillard
changed the title
strict to Type.is_valid_valuestrict argument to Type.is_valid_value
ricardoV94
approved these changes
Jun 14, 2022
Codecov Report
@@ Coverage Diff @@
## main #995 +/- ##
==========================================
- Coverage 79.27% 79.26% -0.01%
==========================================
Files 152 152
Lines 47937 47932 -5
Branches 10915 10914 -1
==========================================
- Hits 38000 37995 -5
Misses 7429 7429
Partials 2508 2508
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the
RandomTypeby makingRandomType.is_valid_valuedepend onRandomType.filter, as the baseTypeimplementation does. It also adds some typing information toRandomType.Closes #992