Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use input shapes to compute output shape in Elemwise.infer_shape #981

Merged

Conversation

brandonwillard
Copy link
Member

Closes #979

@brandonwillard brandonwillard self-assigned this Jun 6, 2022
@brandonwillard brandonwillard force-pushed the fix-elemwise-infer_shape branch 4 times, most recently from 9e882ee to 335e12a Compare June 7, 2022 16:42
@brandonwillard brandonwillard force-pushed the fix-elemwise-infer_shape branch from 335e12a to 3c7591b Compare June 7, 2022 22:30
@codecov
Copy link

codecov bot commented Jun 7, 2022

Codecov Report

Merging #981 (3c7591b) into main (8559ae4) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #981      +/-   ##
==========================================
+ Coverage   79.25%   79.26%   +0.01%     
==========================================
  Files         152      152              
  Lines       47941    47927      -14     
  Branches    10916    10912       -4     
==========================================
- Hits        37996    37990       -6     
+ Misses       7432     7429       -3     
+ Partials     2513     2508       -5     
Impacted Files Coverage Δ
aesara/tensor/elemwise.py 88.50% <100.00%> (+0.33%) ⬆️
aesara/tensor/extra_ops.py 88.93% <100.00%> (-0.02%) ⬇️
aesara/tensor/basic.py 90.78% <0.00%> (+0.12%) ⬆️
aesara/tensor/subtensor_opt.py 86.32% <0.00%> (+0.26%) ⬆️

@brandonwillard brandonwillard requested a review from ricardoV94 June 8, 2022 11:24
@brandonwillard brandonwillard merged commit 064e72f into aesara-devs:main Jun 8, 2022
@brandonwillard brandonwillard deleted the fix-elemwise-infer_shape branch June 8, 2022 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working important shape inference
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Elemwise.infer_shape incorrectly relies on its outputs' broadcast patterns
2 participants