Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow newlines in __str__ output printed by fgraph_to_python #975

Conversation

brandonwillard
Copy link
Member

This PR fixes a bug in aesara.link.utils.fgraph_to_python that doesn't handle multi-line Apply and/or Op __str__s.

@brandonwillard brandonwillard linked an issue Jun 3, 2022 that may be closed by this pull request
@brandonwillard brandonwillard self-assigned this Jun 3, 2022
@brandonwillard brandonwillard added bug Something isn't working JAX Involves JAX transpilation Numba Involves Numba transpilation labels Jun 3, 2022
@codecov
Copy link

codecov bot commented Jun 3, 2022

Codecov Report

Merging #975 (d2ed945) into main (c028e38) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #975   +/-   ##
=======================================
  Coverage   79.25%   79.25%           
=======================================
  Files         152      152           
  Lines       47939    47941    +2     
  Branches    10916    10916           
=======================================
+ Hits        37996    37998    +2     
  Misses       7429     7429           
  Partials     2514     2514           
Impacted Files Coverage Δ
aesara/link/utils.py 61.12% <100.00%> (+0.24%) ⬆️

@brandonwillard brandonwillard merged commit 45642af into aesara-devs:main Jun 3, 2022
@brandonwillard brandonwillard deleted the fix-str-newlines-fgraph_to_python branch June 3, 2022 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working JAX Involves JAX transpilation Numba Involves Numba transpilation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug in formatting of generated JAX code files.
1 participant