Increase lock scope in ModuleCache.refresh
#969
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brandonwillard
force-pushed
the
fix-ModuleCache-refresh-race-issue
branch
from
20f79d0 to
6e61f0e
Compare
brandonwillard
force-pushed
the
fix-ModuleCache-refresh-race-issue
branch
from
6e61f0e to
f739a92
Compare
Codecov Report
@@ Coverage Diff @@
## main #969 +/- ##
==========================================
+ Coverage 79.20% 79.25% +0.05%
==========================================
Files 152 152
Lines 47939 47939
Branches 10916 10916
==========================================
+ Hits 37969 37996 +27
+ Misses 7464 7429 -35
- Partials 2506 2514 +8
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #858
I was able to confirm that the newly added test raises exceptions—due to the race condition—when the fix isn't in place (see here).