-
-
Notifications
You must be signed in to change notification settings - Fork 151
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove deprecated Flatten
and Tile
Op
s
#948
Conversation
Codecov Report
@@ Coverage Diff @@
## main #948 +/- ##
==========================================
+ Coverage 79.10% 79.20% +0.10%
==========================================
Files 152 152
Lines 48061 47937 -124
Branches 10934 10916 -18
==========================================
- Hits 38017 37967 -50
+ Misses 7534 7464 -70
+ Partials 2510 2506 -4
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Need to fix a merge conflict
@ricardoV94 Thanks for the review! I merged in changes that @brandonwillard made after my PR |
I think you will have to rebase from main instead of merging. Can you confirm @brandonwillard? |
I can do that as well and re-push |
a719c9b
to
8c88266
Compare
Are you able to restart the checks? Seemed to cancel with force push, but not restart |
8c88266
to
7ff73e6
Compare
I rebased on main again, tests should rerun now |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good; much appreciated!
This PR closes #399 and removes long deprecated
Flatten
andTile
Op
s.I'm not sure if
unittest.rst
is maintained, but I made a change to the code there.My dev environment is not quite right, so I couldn't confirm if the debug output in
debug_faq.rst
(line 158) needed to be updated.Here are a few important guidelines and requirements to check before your PR can be merged:
pre-commit
is installed and set up.Don't worry, your PR doesn't need to be in perfect order to submit it. As development progresses and/or reviewers request changes, you can always rewrite the history of your feature/PR branches.
If your PR is an ongoing effort and you would like to involve us in the process, simply make it a draft PR.