-
-
Notifications
You must be signed in to change notification settings - Fork 152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add power and zipf RV #1448
Merged
Merged
Add power and zipf RV #1448
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Smit-create
added
enhancement
New feature or request
random variables
Involves random variables and/or sampling
NumPy compatibility
Op implementation
Involves the implementation of an Op
labels
Feb 21, 2023
Looks good! Can you also add the distributions to the documentation? I see that the tests fail in CI, but they don't on my machine. We need to figure out what's happening here; is NumPy's output consistent to begin with? |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1448 +/- ##
=======================================
Coverage 74.86% 74.87%
=======================================
Files 194 194
Lines 50107 50123 +16
Branches 12098 12098
=======================================
+ Hits 37514 37530 +16
Misses 10266 10266
Partials 2327 2327
|
brandonwillard
force-pushed
the
i-1352-1350
branch
from
February 27, 2023 22:58
a6e447f
to
775076d
Compare
brandonwillard
approved these changes
Feb 27, 2023
Is this good to merge? |
Yes, thanks a lot! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
enhancement
New feature or request
NumPy compatibility
Op implementation
Involves the implementation of an Op
random variables
Involves random variables and/or sampling
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1352
Fixes #1350
Here are a few important guidelines and requirements to check before your PR can be merged:
pre-commit
is installed and set up.