-
-
Notifications
You must be signed in to change notification settings - Fork 152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename floor_div
to floor_divide
to match NumPy's API
#1432
Conversation
e2726b4
to
4b6c58a
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1432 +/- ##
==========================================
- Coverage 74.86% 74.86% -0.01%
==========================================
Files 194 194
Lines 50107 50105 -2
Branches 12098 12098
==========================================
- Hits 37514 37512 -2
Misses 10266 10266
Partials 2327 2327
|
aesara/tensor/math.py
Outdated
@@ -1771,8 +1771,8 @@ def minimum(x, y): | |||
|
|||
|
|||
def divmod(x, y): | |||
"""elementvise divmod, using floor_div and mod_check""" | |||
return floor_div(x, y), mod_check(x, y) | |||
"""elementvise divmod, using floor_divide and mod_check""" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"""elementvise divmod, using floor_divide and mod_check""" | |
"""Element-wise `divmod`, using `floor_divide` and `mod_check`.""" |
e692981
to
2838f22
Compare
I believe there is still some |
7856f72
to
6945294
Compare
Hi @brandonwillard, I made the below changes
|
6945294
to
3855526
Compare
aesara/scalar/basic.py
Outdated
|
||
|
||
floor_div = int_div | ||
floor_divide = IntDiv(upcast_out, name="floor_divide") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since we are renaming everything, should we also rename the class IntDiv
, I thing that will make our code consistence
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's a good idea
a77514b
to
333fb47
Compare
333fb47
to
1e455e3
Compare
Hi @rlouf I have renamed |
floor_div
to floor_divide
to match with NumPyfloor_div
to floor_divide
and true_div
to true_divide
to match with NumPy
floor_div
to floor_divide
and true_div
to true_divide
to match with NumPyfloor_div
to floor_divide
to match NumPy's API
Looks good to me. Thank you for contributing @sudarsan2k5, NumPy compatibility is very important. |
Addressing #1212
floor_div
withfloor_divide
int_div
pre-commit
is installed and set up.