-
-
Notifications
You must be signed in to change notification settings - Fork 152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Exclude doc/ from sdist #1408
Exclude doc/ from sdist #1408
Conversation
In the spirit of changing no more than one thing at a time, I don't see any rush on merging this. We may want to wait until after the Hatch stuff is already released and shown to be stable. |
Strange, this is failing with
This doesn't make any sense to me yet, and it builds for me locally. I wonder if this could be related in some way to #1409? I'm out of time right now, so I'll have to come back to this if someone else doesn't get it first. |
|
It seems that the doc/ directory isn't doing anything but taking up space in the sdist. (Deleting reduces the .tar.gz sdist from 3.85MB to 1.34MB.) Note: doc/.build/PLACEHOLDER is still included. It's 14 years old now, so perhaps it is unnecessary and can be deleted? Closes aesara-devs#1397
Before: LICENSE.txt is a symlink to doc/LICENSE.txt After: LICENSE.txt is no longer a symlink, doc/LICENSE.txt is deleted
07f7564
to
8b61148
Compare
Thanks @dgerlanc for solving the mystery! I think it's fairly standard these days to just have |
Thanks as always, @maresb! |
It seems that the doc/ directory isn't doing anything but taking up space in the sdist. (Deleting reduces the .tar.gz sdist from 3.85MB to 1.34MB.)
Note: doc/.build/PLACEHOLDER is still included. It's 14 years old now, so perhaps it is unnecessary and can be deleted?
Closes #1397
Thank you for opening a PR!
Here are a few important guidelines and requirements to check before your PR can be merged:
pre-commit
is installed and set up.Don't worry, your PR doesn't need to be in perfect order to submit it. As development progresses and/or reviewers request changes, you can always rewrite the history of your feature/PR branches.
If your PR is an ongoing effort and you would like to involve us in the process, simply make it a draft PR.