-
-
Notifications
You must be signed in to change notification settings - Fork 152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update setup-python action version #1376
Update setup-python action version #1376
Conversation
9c937a8
to
3e0b176
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, as long as everything passes this looks very good to me. I would have done this in the other PR except I wanted to keep the changes focused and minimal (easier one thing at a time). And I can rebase #1375. Thanks!
9e2e1dc
to
9755d59
Compare
Along these lines, how much longer do you plan to support Python 3.7? Support in other libraries is beginning to be phased out. It would be nice to be able to bump |
I added a few more minor fixes that should help the Sphinx documentation generation process. |
I'm fine with that change. We might want to bundle it with the next big release, though. |
Just saw that a test for #4324 failed with a nonsensical error from setup-python, so hopefully this will help. https://github.com/aesara-devs/aesara/actions/runs/3796153938/jobs/6455995636 |
These functions are no longer in `aesara.tensor.basic`, so they were broken in the Sphinx documentation generation process.
9755d59
to
4108323
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1376 +/- ##
=======================================
Coverage 74.68% 74.69%
=======================================
Files 195 195
Lines 49744 49748 +4
Branches 10529 10529
=======================================
+ Hits 37153 37157 +4
Misses 10266 10266
Partials 2325 2325
|
Looks ready to merge |
Perhaps we should configure one/some of those actions which automatically opens PRs to update these things. |
That would be cool! |
This PR updates the
setup-python
action in our workflows, which should remove a few of the deprecation warnings.It looks like there are some Python version issues in the docs build process, so this PR includes some commits that address those issues.