Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update setup-python action version #1376

Merged

Conversation

brandonwillard
Copy link
Member

@brandonwillard brandonwillard commented Dec 29, 2022

This PR updates the setup-python action in our workflows, which should remove a few of the deprecation warnings.

It looks like there are some Python version issues in the docs build process, so this PR includes some commits that address those issues.

@brandonwillard brandonwillard force-pushed the update-setup-python-actions branch from 9c937a8 to 3e0b176 Compare December 29, 2022 18:11
@brandonwillard brandonwillard added the CI Involves continuous integration label Dec 29, 2022
@brandonwillard brandonwillard self-assigned this Dec 29, 2022
maresb
maresb previously approved these changes Dec 29, 2022
Copy link
Contributor

@maresb maresb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, as long as everything passes this looks very good to me. I would have done this in the other PR except I wanted to keep the changes focused and minimal (easier one thing at a time). And I can rebase #1375. Thanks!

@maresb
Copy link
Contributor

maresb commented Dec 29, 2022

Along these lines, how much longer do you plan to support Python 3.7? Support in other libraries is beginning to be phased out. It would be nice to be able to bump requires-python to 3.8.

@brandonwillard
Copy link
Member Author

I added a few more minor fixes that should help the Sphinx documentation generation process.

@brandonwillard
Copy link
Member Author

brandonwillard commented Dec 29, 2022

Along these lines, how much longer do you plan to support Python 3.7? Support in other libraries is beginning to be phased out. It would be nice to be able to bump requires-python to 3.8.

I'm fine with that change. We might want to bundle it with the next big release, though.

@maresb
Copy link
Contributor

maresb commented Dec 29, 2022

Just saw that a test for #4324 failed with a nonsensical error from setup-python, so hopefully this will help.

https://github.com/aesara-devs/aesara/actions/runs/3796153938/jobs/6455995636

These functions are no longer in `aesara.tensor.basic`, so they were broken in
the Sphinx documentation generation process.
@brandonwillard brandonwillard force-pushed the update-setup-python-actions branch from 9755d59 to 4108323 Compare December 29, 2022 19:27
@codecov
Copy link

codecov bot commented Dec 29, 2022

Codecov Report

Merging #1376 (4108323) into main (f874925) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1376   +/-   ##
=======================================
  Coverage   74.68%   74.69%           
=======================================
  Files         195      195           
  Lines       49744    49748    +4     
  Branches    10529    10529           
=======================================
+ Hits        37153    37157    +4     
  Misses      10266    10266           
  Partials     2325     2325           
Impacted Files Coverage Δ
aesara/tensor/math.py 90.39% <100.00%> (-0.02%) ⬇️
aesara/tensor/var.py 87.82% <100.00%> (+0.13%) ⬆️

@maresb
Copy link
Contributor

maresb commented Dec 29, 2022

Looks ready to merge

@maresb
Copy link
Contributor

maresb commented Dec 29, 2022

Perhaps we should configure one/some of those actions which automatically opens PRs to update these things.

@brandonwillard brandonwillard merged commit baa6b7f into aesara-devs:main Dec 30, 2022
@brandonwillard brandonwillard deleted the update-setup-python-actions branch December 30, 2022 01:30
@brandonwillard
Copy link
Member Author

Perhaps we should configure one/some of those actions which automatically opens PRs to update these things.

That would be cool!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI Involves continuous integration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants