-
-
Notifications
You must be signed in to change notification settings - Fork 152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate from setup.cfg to pyproject.toml #1371
Conversation
Ah, looks like I have to modify the GH workflows. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like the flake8
errors might be due to the program not finding the settings in pyproject.toml
(see PyCQA/flake8#234).
pipx install ini2toml[full] ini2toml setup.cfg > pyproject.toml rm setup.cfg
670cbcf
to
127aed1
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1371 +/- ##
==========================================
+ Coverage 74.66% 74.68% +0.02%
==========================================
Files 177 195 +18
Lines 49050 49744 +694
Branches 10400 10529 +129
==========================================
+ Hits 36623 37153 +530
- Misses 10131 10266 +135
- Partials 2296 2325 +29
|
3b3e26c
to
48ed84f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I squashed and updated the project description; otherwise, looks good!
Thanks a lot for the approval! I still want to do one final pass to readd the fields which were dropped by the |
No problem. |
Unsquashing... |
dae7e7d
to
e708ed4
Compare
Co-authored-by: Brandon T. Willard <[email protected]>
e708ed4
to
aafd5fa
Compare
@brandonwillard, got some time on the train today. I think this is now ready to merge. I made an exhaustive comparison with the original Since your last commit, diff --git a/pyproject.toml b/pyproject.toml
index 65a7b0fa0..675601a51 100644
--- a/pyproject.toml
+++ b/pyproject.toml
@@ -75,6 +75,7 @@ platforms = [
"Mac OS-X",
"Unix",
]
+# Not from setup.cfg
include-package-data = false
[tool.setuptools.packages.find]
@@ -82,12 +83,11 @@ exclude = [
"tests",
"tests.*",
]
+# Not from setup.cfg:
namespaces = false
[tool.setuptools.package-data]
"*" = [
- "*.txt",
- "*.rst",
"*.txt",
"*.rst",
"*.cu",
@@ -99,6 +99,8 @@ namespaces = false
"*.cpp",
"ChangeLog",
"c_code/*",
+]
+"aesara" = [
"py.typed",
]
"aesara.misc" = ["*.sh"]
@@ -153,7 +155,7 @@ lines_after_imports = 2
lines_between_sections = 1
honor_noqa = true
skip_gitignore = true
-skip = ["aesara/version.py", "**/__init__.py"]
+skip = ["aesara/version.py"]
skip_glob = ["**/*.pyx"]
[tool.mypy]
@@ -261,6 +263,14 @@ module = ["aesara.tensor.rewriting.basic"]
ignore_errors = true
check_untyped_defs = false
+[[tool.mypy.overrides]]
+module = ["aesara.tensor.rewriting.shape"]
+warn_unused_ignores = false
+
+[[tool.mypy.overrides]]
+module = ["aesara.tensor.rewriting.elemwise"]
+warn_unused_ignores = false
+
[[tool.mypy.overrides]]
module = ["aesara.tensor.subtensor"]
ignore_errors = true
@@ -326,6 +336,10 @@ module = ["aesara.tensor.random.utils"]
ignore_errors = true
check_untyped_defs = false
+[[tool.mypy.overrides]]
+module = ["aesara.scan.op"]
+warn_unused_ignores = false
+
[[tool.mypy.overrides]]
module = ["aesara.link.numba.dispatch.extra_ops"]
ignore_errors = true Explanations: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!
Migrates from
setup.cfg
topyproject.toml
. I confirmed that the contents of both the sdist and wheel are equivalent up to trivial changes.PKG-INFO
before:PKG-INFO
after:Thank you for opening a PR!
Here are a few important guidelines and requirements to check before your PR can be merged:
pre-commit
is installed and set up.Don't worry, your PR doesn't need to be in perfect order to submit it. As development progresses and/or reviewers request changes, you can always rewrite the history of your feature/PR branches.
If your PR is an ongoing effort and you would like to involve us in the process, simply make it a draft PR.