-
-
Notifications
You must be signed in to change notification settings - Fork 152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add JAX implementation for LogNormalRV
#1346
Conversation
[ | ||
set_test_value( | ||
at.lvector(), | ||
np.array([0, 0], dtype=np.int64), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seem scipy
's implementation does not accept a loc
param ? https://docs.scipy.org/doc/scipy/reference/generated/scipy.stats.lognorm.html
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems to work with something like scipy.stats.lognorm(1, loc=10).rvs()
.
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1346 +/- ##
=======================================
Coverage 74.35% 74.36%
=======================================
Files 177 177
Lines 49036 49046 +10
Branches 10379 10379
=======================================
+ Hits 36461 36471 +10
Misses 10283 10283
Partials 2292 2292
|
Thank you for contributing! |
Closes: #1325
References: