Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add basic overloads for Numba sparse types #1337

Conversation

brandonwillard
Copy link
Member

@brandonwillard brandonwillard commented Dec 7, 2022

This PR adds some basic overloads for Numba sparse types (e.g. np.shape, .ndim, etc.) This is a follow-up to #1336.

  • Implement np.shape
  • Implement .ndim
  • Implement .copy

@brandonwillard brandonwillard marked this pull request as draft December 7, 2022 01:35
@brandonwillard brandonwillard added Numba Involves Numba transpilation sparse tensors labels Dec 7, 2022
@brandonwillard brandonwillard force-pushed the add-basic-sparse-numba-overloads branch 4 times, most recently from e758127 to fe7b16f Compare December 7, 2022 23:56
@brandonwillard brandonwillard force-pushed the add-basic-sparse-numba-overloads branch 2 times, most recently from aa363f5 to 200d237 Compare December 8, 2022 01:28
@brandonwillard brandonwillard force-pushed the add-basic-sparse-numba-overloads branch from 200d237 to 4de8dae Compare December 8, 2022 01:45
@codecov
Copy link

codecov bot commented Dec 8, 2022

Codecov Report

Merging #1337 (4de8dae) into main (75f09bf) will increase coverage by 0.00%.
The diff coverage is 80.39%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1337   +/-   ##
=======================================
  Coverage   74.27%   74.27%           
=======================================
  Files         175      175           
  Lines       48841    48886   +45     
  Branches    10369    10375    +6     
=======================================
+ Hits        36276    36311   +35     
- Misses      10276    10282    +6     
- Partials     2289     2293    +4     
Impacted Files Coverage Δ
aesara/link/numba/dispatch/basic.py 92.24% <ø> (-0.07%) ⬇️
aesara/link/numba/dispatch/sparse.py 92.53% <80.00%> (-7.47%) ⬇️
aesara/link/numba/linker.py 100.00% <100.00%> (ø)

@brandonwillard brandonwillard marked this pull request as ready for review December 8, 2022 04:24
@brandonwillard brandonwillard added the enhancement New feature or request label Dec 8, 2022
@brandonwillard brandonwillard merged commit 5dee3c7 into aesara-devs:main Dec 8, 2022
@brandonwillard brandonwillard deleted the add-basic-sparse-numba-overloads branch December 8, 2022 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Numba Involves Numba transpilation sparse tensors
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant