-
-
Notifications
You must be signed in to change notification settings - Fork 151
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement generalized gamma distribution #1059
Implement generalized gamma distribution #1059
Conversation
ade3d5a
to
052447b
Compare
Codecov Report
@@ Coverage Diff @@
## main #1059 +/- ##
=======================================
Coverage 79.25% 79.25%
=======================================
Files 152 152
Lines 47875 47887 +12
Branches 10906 10907 +1
=======================================
+ Hits 37942 37954 +12
Misses 7436 7436
Partials 2497 2497
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, although the commits need to be squashed/rebased before merging (because there's a merge commit in this branch).
7fa673c
to
d9ede7d
Compare
just rebased and squashed! Any advice on how to coordinate this PR with the corresponding PyMC PR? |
You can increment the required Aesara version in your PyMC PR; that will at least guarantee that your changes will only apply to a version of Aesara with these changes. |
Thank you for opening a PR!
This PR implements an Op for a Generalized Gamma Random Variable with the parameterization GG(alpha, p, lambd). This corresponds to scipy in the following mapping:
scipy.stats.gengamma(a=alpha/p, c=p, scale=lambd)
.This goes along with the following PyMC PR to implement the Generalized Gamma distribution
Here are a few important guidelines and requirements to check before your PR can be merged:
pre-commit
is installed and set up.Don't worry, your PR doesn't need to be in perfect order to submit it. As development progresses and/or reviewers request changes, you can always rewrite the history of your feature/PR branches.
If your PR is an ongoing effort and you would like to involve us in the process, simply make it a draft PR.