Update PyPI workflow to also build a wheel #1048
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brandonwillard
added
enhancement
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1048 +/- ##
=======================================
Coverage 79.26% 79.26%
=======================================
Files 152 152
Lines 47874 47874
Branches 10908 10908
=======================================
Hits 37948 37948
Misses 7429 7429
Partials 2497 2497 |
brandonwillard
changed the title
brandonwillard
changed the title
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello Y'all,
PR solves #1047. TLDR: pypi can't figure the dependencies of aesara if the wheel isn't uploaded.
During the github action that publishes to pypi make sure to not only build a sdist but also a wheel. This is similar to what happens when executing
make pypi. Twine (inside pypa/gh-action-pypi-publish@master) will automatically upload the wheel first such that pypi can extract the dependencies better and the pypi json api doesn't returnrequires_dist = nullThank you for this awesome tool! 🙇♂️