Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove useless complex conjugate Ops from graphs #1025

Merged

Conversation

brandonwillard
Copy link
Member

This PR adds some simple checks and rewrites that avoid adding useless complex conjugate Ops to graphs.

@brandonwillard brandonwillard added enhancement New feature or request graph rewriting labels Jul 1, 2022
@brandonwillard brandonwillard force-pushed the remove-useless-conj branch 3 times, most recently from 3abe874 to 889a1cb Compare July 3, 2022 21:20
@codecov
Copy link

codecov bot commented Jul 4, 2022

Codecov Report

Attention: Patch coverage is 96.87500% with 1 line in your changes missing coverage. Please review.

Project coverage is 79.26%. Comparing base (ecd6b49) to head (199b4eb).
Report is 526 commits behind head on main.

Files Patch % Lines
aesara/sparse/type.py 80.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1025      +/-   ##
==========================================
+ Coverage   79.23%   79.26%   +0.02%     
==========================================
  Files         152      152              
  Lines       47953    47978      +25     
  Branches    10919    10922       +3     
==========================================
+ Hits        37995    38028      +33     
+ Misses       7449     7442       -7     
+ Partials     2509     2508       -1     
Files Coverage Δ
aesara/sparse/basic.py 82.89% <100.00%> (+0.42%) ⬆️
aesara/tensor/math.py 89.78% <100.00%> (+0.05%) ⬆️
aesara/tensor/math_opt.py 87.27% <100.00%> (+0.05%) ⬆️
aesara/sparse/type.py 74.76% <80.00%> (+2.65%) ⬆️

@brandonwillard brandonwillard merged commit 584496d into aesara-devs:main Jul 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request graph rewriting
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant