Fix Op.perform type hint
#1016
Merged
Fix Op.perform type hint
#1016
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1016 +/- ##
=======================================
Coverage 79.26% 79.26%
=======================================
Files 152 152
Lines 47873 47873
Branches 10908 10908
=======================================
Hits 37947 37947
Misses 7429 7429
Partials 2497 2497
|
twiecki
previously approved these changes
Jul 3, 2022
brandonwillard
requested changes
Jul 3, 2022
michaelosthege
commented
Jul 4, 2022
aesara/graph/op.py
Outdated
| @@ -17,6 +17,7 @@ | |||
| cast, | |||
| ) | |||
|
|
|||
| import numpy as np | |||
There was a problem hiding this comment.
Suggested change
| import numpy as np |
brandonwillard
approved these changes
Jul 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The type hint of the
inputsparameter toOp.performwas wrong.The docstring was correct.
This PR fixes the type hint.