Skip to content

Commit

Permalink
Downgrade flake8 pre-commit for py37 compatibility
Browse files Browse the repository at this point in the history
Aesara's minimum-supported Python version is 3.7, and it's probably
really convenient to develop with that version in order to avoid using
incompatible language features. Then of course you want to run
pre-commit, but for that you either need a higher version of Python
(>=3.8.1) or a lower (<=5.0.4) version of flake8.

It seems to me like the most straightforward solution is to revert
flake8 to 5.0.4 (the second-most-recent release, August) until
Aesara drops support for Python 3.7.
  • Loading branch information
maresb committed Dec 15, 2022
1 parent 3418496 commit d29e311
Showing 1 changed file with 3 additions and 2 deletions.
5 changes: 3 additions & 2 deletions .pre-commit-config.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -25,10 +25,11 @@ repos:
- id: black
language_version: python3
- repo: https://github.com/pycqa/flake8
rev: 6.0.0
# NOTE: flake8 v6 requires python >=3.8.1 but
# Aesara still supports python 3.7.
rev: 5.0.4
hooks:
- id: flake8
language_version: python39
- repo: https://github.com/pycqa/isort
rev: 5.10.1
hooks:
Expand Down

0 comments on commit d29e311

Please sign in to comment.