Add testing checking copying of many small files

Issue openzfs#7401 identified data loss when many small files are being copied. Add a test to check for this condition. Signed-off-by: Antonio Russo <[email protected]>
aerusso · Apr 8, 2018 · efd91aa · efd91aa
1 parent 6c9af9e
commit efd91aa
Show file tree

Hide file tree

Showing 8 changed files with 50 additions and 0 deletions.
diff --git a/configure.ac b/configure.ac
@@ -252,6 +252,7 @@ AC_CONFIG_FILES([
 	tests/zfs-tests/tests/functional/cli_user/zpool_iostat/Makefile
 	tests/zfs-tests/tests/functional/cli_user/zpool_list/Makefile
 	tests/zfs-tests/tests/functional/compression/Makefile
+	tests/zfs-tests/tests/functional/cp_many_files/Makefile
 	tests/zfs-tests/tests/functional/ctime/Makefile
 	tests/zfs-tests/tests/functional/deadman/Makefile
 	tests/zfs-tests/tests/functional/delegate/Makefile

diff --git a/tests/runfiles/linux.run b/tests/runfiles/linux.run
@@ -469,6 +469,10 @@ tests = ['compress_001_pos', 'compress_002_pos', 'compress_003_pos',
     'compress_004_pos']
 tags = ['functional', 'compression']
 
+[tests/functional/cp_many_files]
+tests = ['cp_001']
+tags = ['functional','cp_many_files']
+
 [tests/functional/ctime]
 tests = ['ctime_001_pos' ]
 tags = ['functional', 'ctime']

diff --git a/tests/zfs-tests/tests/functional/Makefile.am b/tests/zfs-tests/tests/functional/Makefile.am
@@ -13,6 +13,7 @@ SUBDIRS = \
 	cli_root \
 	cli_user \
 	compression \
+	cp_many_files \
 	ctime \
 	deadman \
 	delegate \

diff --git a/tests/zfs-tests/tests/functional/cp_many_files/Makefile.am b/tests/zfs-tests/tests/functional/cp_many_files/Makefile.am
@@ -0,0 +1,9 @@
+pkgdatadir = $(datadir)/@PACKAGE@/zfs-tests/tests/functional/cp_many_files
+
+dist_pkgdata_SCRIPTS = \
+	cleanup.ksh \
+	setup.ksh \
+	cp_001.ksh
+
+dist_pkgdata_DATA = \
+	cp_many_files.cfg
diff --git a/tests/zfs-tests/tests/functional/cp_many_files/cleanup.ksh b/tests/zfs-tests/tests/functional/cp_many_files/cleanup.ksh
@@ -0,0 +1,5 @@
+#!/bin/ksh -p
+
+source "${STF_SUITE}/include/libtest.shlib"
+
+default_container_cleanup
diff --git a/tests/zfs-tests/tests/functional/cp_many_files/cp_001.ksh b/tests/zfs-tests/tests/functional/cp_many_files/cp_001.ksh
@@ -0,0 +1,24 @@
+#!/bin/ksh -p
+
+source "${STF_SUITE}/include/libtest.shlib"
+source "${STF_SUITE}/tests/functional/cp_many_files/cp_many_files.cfg"
+
+log_assert "Check that copying many small files is safe"
+
+log_must mkdir $TESTDIR/SRC
+
+for i in $(seq 1 ${CP_FILE_COUNT}) ; do
+    echo $i > $TESTDIR/SRC
+done
+
+log_note "Ensure we produced the correct number of files"
+log_must [[ $(find SRC -type f|wc -l) -eq ${CP_FILE_COUNT} ]]
+
+log_note "Ensure we copy the files"
+log_must cp -r $TESTDIR/SRC $TESTDIR/DST
+
+if [[ $(find DST -type f|wc -l) -eq ${CP_FILE_COUNT} ]] ; then
+    log_pass "Copied all ${CP_FILE_COUNT} files"
+else
+    log_fail "$(find SRC -type f|wc -l) is not ${CP_FILE_COUNT}"
+fi
diff --git a/tests/zfs-tests/tests/functional/cp_many_files/cp_many_files.cfg b/tests/zfs-tests/tests/functional/cp_many_files/cp_many_files.cfg
@@ -0,0 +1 @@
+export CP_FILE_COUNT=300000
diff --git a/tests/zfs-tests/tests/functional/cp_many_files/setup.ksh b/tests/zfs-tests/tests/functional/cp_many_files/setup.ksh
@@ -0,0 +1,5 @@
+#!/bin/ksh -p
+
+source "${STF_SUITE}/include/libtest.shlib"
+
+default_container_setup ${DISKS%% *}